This repository has been archived by the owner on Apr 22, 2020. It is now read-only.
Removes SBT dependency from core module #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedefernandez
force-pushed
the
ff-removes-sbt-dependency-from-core
branch
from
2555468
to
40d4955
Compare
fedefernandez
force-pushed
the
ff-removes-sbt-dependency-from-core
branch
from
40d4955
to
c595b28
Compare
juanpedromoreno
approved these changes
Oct 13, 2017
| @@ -53,7 +53,7 @@ package object io { | |||
|
|
|||
| def toPath: Path = get(filename) | |||
|
|
|||
| def toFile: File = file(filename.fixPath) | |||
| def toFile: File = new File(filename.fixPath) | |||
There was a problem hiding this comment.
IO.file to be consistent?
|
|
||
| object IO { | ||
|
|
||
| def file(path: String): File = new File(path) |
| writer.close() | ||
| } | ||
|
|
||
| def relativize(base: File, file: File): Option[String] = { |
There was a problem hiding this comment.
|
Thanks for the review. We need to avoid the use of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the SBT dependency from the core module. The biggest change is that the runnable classes are moved from the core to the plugin, so it can lead some incompatibility issues.